Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versions issue with 3.21 assests #10309

Closed
ronaldpetty opened this issue Jul 25, 2022 · 4 comments
Closed

Versions issue with 3.21 assests #10309

ronaldpetty opened this issue Jul 25, 2022 · 4 comments
Assignees
Labels

Comments

@ronaldpetty
Copy link

The 3.21.3 protoc assets are missing the major version in the URL and names.

https://github.com/protocolbuffers/protobuf/releases/download/v21.3/protoc-21.3-linux-x86_64.zip

I thought I would find.

https://github.com/protocolbuffers/protobuf/releases/download/v3.21.3/protoc-3.21.3-linux-x86_64.zip

It does report correctly though.

root@build:/data# /protoc/bin/protoc --version
libprotoc 3.21.3

Not sure if its a bug and missed something.

@ronaldpetty ronaldpetty added the untriaged auto added to all issues by default when created. label Jul 25, 2022
@fowles
Copy link
Contributor

fowles commented Jul 25, 2022

We have changed our major version policy as part of https://developers.google.com/protocol-buffers/docs/news/2022-05-06#versioning so 21.3 is correct.

The binary itself is still reporting 3.21.3, which we may need to look into.

@fowles fowles added the protoc label Jul 25, 2022
@fowles fowles removed the untriaged auto added to all issues by default when created. label Jul 25, 2022
@ronaldpetty
Copy link
Author

Thank you @fowles , should I make a new ticket for the binary or just leave this one? Sorry I missed the doc, I did try to look around, just missed it I guess.

@fowles
Copy link
Contributor

fowles commented Jul 25, 2022

Just leave this one. We are talking about how to resolve it internally

@deannagarcia
Copy link
Member

Fixed with #10386. We need to do more work to migrate the version completely over since our C++ runtime version and compiler version have become very mixed together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants