Skip to content

Commit

Permalink
Support non ascii commandline args (#14197)
Browse files Browse the repository at this point in the history
Using none ASCII chars for protoc on Windows are not handled well.
This adresses argument file at a location where either directory, or filename contains Unicode chars.

Specifically because MsBuild tool saves argument file in with the UserName appended to the .rsp file.
dotnet/msbuild#9232

But in general we should really handle if none ascii chars are in the path.

Closes #14197

COPYBARA_INTEGRATE_REVIEW=#14197 from hknielsen:support-non-ascii-commandline-args 673d575
PiperOrigin-RevId: 568722987
  • Loading branch information
hknielsen authored and copybara-github committed Sep 27, 2023
1 parent caa4627 commit 8fc0544
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions build_defs/cpp_opts.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ LINK_OPTS = select({
"//build_defs:config_msvc": [
# Suppress linker warnings about files with no symbols defined.
"-ignore:4221",
"/utf-8",
],
"@platforms//os:macos": [
"-lpthread",
Expand Down

0 comments on commit 8fc0544

Please sign in to comment.