Skip to content

Commit

Permalink
Hide ruby native extension symbols on FreeBSD (#10832)
Browse files Browse the repository at this point in the history
They probably should be hidden on every ELF platform, but for now only do it on Darwin, Linux, and FreeBSD.

This prevents some load-time errors that have been seen in GitLab's gitaly server, and in a few other places.

Closes #10832

COPYBARA_INTEGRATE_REVIEW=#10832 from dankm:hide-symbols 4cb59f2
PiperOrigin-RevId: 490522474
  • Loading branch information
dankm authored and copybara-github committed Nov 23, 2022
1 parent d083ec5 commit 2a73e3b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ruby/ext/google/protobuf_c/extconf.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

dir_config(ext_name)

if RUBY_PLATFORM =~ /darwin/ || RUBY_PLATFORM =~ /linux/
if RUBY_PLATFORM =~ /darwin/ || RUBY_PLATFORM =~ /linux/ || RUBY_PLATFORM =~ /freebsd/
$CFLAGS += " -std=gnu99 -O3 -DNDEBUG -fvisibility=hidden -Wall -Wsign-compare -Wno-declaration-after-statement"
else
$CFLAGS += " -std=gnu99 -O3 -DNDEBUG"
Expand Down

0 comments on commit 2a73e3b

Please sign in to comment.