Skip to content

Commit

Permalink
Cherry-picked Bazel fix from PR #5085 (#5382)
Browse files Browse the repository at this point in the history
* use flag_values = {"@bazel_tools//tools/cpp:compiler": "x"} for compiler config_settings

* Create compiler_config_setting.bzl
  • Loading branch information
acozzette authored and anandolee committed Nov 21, 2018
1 parent 740ff02 commit 046e8fb
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 4 deletions.
7 changes: 3 additions & 4 deletions BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,9 @@ COPTS = select({
],
})

config_setting(
name = "msvc",
values = { "compiler": "msvc-cl" },
)
load(":compiler_config_setting.bzl", "create_compiler_config_setting")

create_compiler_config_setting(name = "msvc", value = "msvc-cl")

config_setting(
name = "android",
Expand Down
21 changes: 21 additions & 0 deletions compiler_config_setting.bzl
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
"""Creates config_setting that allows selecting based on 'compiler' value."""

def create_compiler_config_setting(name, value):
# The "do_not_use_tools_cpp_compiler_present" attribute exists to
# distinguish between older versions of Bazel that do not support
# "@bazel_tools//tools/cpp:compiler" flag_value, and newer ones that do.
# In the future, the only way to select on the compiler will be through
# flag_values{"@bazel_tools//tools/cpp:compiler"} and the else branch can
# be removed.
if hasattr(cc_common, "do_not_use_tools_cpp_compiler_present"):
native.config_setting(
name = name,
flag_values = {
"@bazel_tools//tools/cpp:compiler": value,
},
)
else:
native.config_setting(
name = name,
values = {"compiler": value},
)

0 comments on commit 046e8fb

Please sign in to comment.