Skip to content

Commit

Permalink
Specify os and cpu for release name to avoid duplicates
Browse files Browse the repository at this point in the history
actions/upload-artifact@4 made a breaking change to fail on duplicate
names. I think we are seeing Windows release errors as a result since
both x64_x86 and x64 are named 'releases'.

This change just tags the os and cpu onto the release dir name to
reflect the specific build.
  • Loading branch information
dibenede committed Jul 18, 2024
1 parent 16cb293 commit aa988c9
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,6 @@ jobs:
node-version: 20
cache: ${{ !env.ACT && 'npm' || '' }} # cache API not available in ACT

- uses: bazel-contrib/[email protected]
with:
token: ${{ secrets.GITHUB_TOKEN }}

- name: Install Protoc
run: |
echo "Fetching protoc"
Expand Down Expand Up @@ -108,7 +104,7 @@ jobs:

- uses: actions/upload-artifact@v4
with:
name: releases
name: release-${{ matrix.os }}-${{ matrix.cpu }}
path: out

release:
Expand All @@ -122,7 +118,7 @@ jobs:
steps:
- uses: actions/download-artifact@v4
with:
name: releases
name: release-${{ matrix.os }}-${{ matrix.cpu }}

- name: Release
uses: svenstaro/upload-release-action@v2
Expand Down

0 comments on commit aa988c9

Please sign in to comment.