-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release 6.9.0 #1374
chore: release 6.9.0 #1374
Conversation
This PR is magical ⭐️, It's generated automatically by the tool release-please, based on the commit history (it understands conventional commits which we've been starting to use for newer commits we land). When landed, this PR will automatically create a GitHub release, but will not yet publish to npm; this is an option for us to setup in the future if we would like, and we're getting good about labeling our commits. CC: @dcodeIO, wanted to make sure you're in the loop on this update, and are okay with the approach. |
CHANGELOG.md
Outdated
## Fixed | ||
[:hash:](https://github.com/dcodeIO/protobuf.js/commit/e8449c4bf1269a2cc423708db6f0b47a383d33f0) Fix package browser field descriptor ([#1046](https://github.com/dcodeIO/protobuf.js/issues/1046))<br /> | ||
[:hash:](https://github.com/dcodeIO/protobuf.js/commit/996b3fa0c598ecc73302bfc39208c44830f07b1a) Fix static codegen issues with uglifyjs3<br /> | ||
[:hash:](https://github.com/dcodeIO/protobuf.js/commit/a06317139b92fdd8c6b3b188fb7b9704dc8ccbf1) Fix lint issues / pbts on windows<br /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It didn't do a good job of detecting the starting point of the old CHANGELOG, we will be submitting a PR to fix this.
I for one welcome our new robot overlords. Perhaps it makes sense to give #1356 a look before tagging a 6.9.0? |
@dcodeIO sounds good, we can hold our horses before we merge this. @alexander-fenster and I were talking about maybe adding a feature where you could add a tag and create a candidate release from this PR, without merging it, so folks could: npm i protobufjs@next |
f1fd8ba
to
15ed8a0
Compare
@dcodeIO are you comfortable with this slight change in template template format going forward, we no longer have the #️⃣. It is possible to add new templates to |
99316a5
to
0f8008c
Compare
c596501
to
42f49b4
Compare
I have just released |
A candidate release, |
We ran all kinds of integration tests and we're pretty sure it's safe to release it, but let's still do it on Monday and not on Friday :) As soon as this PR is merged, the robot will do its job and we'll officially declare auto-publishing working. |
🤖 I have created a release *beep* *boop*
6.9.0 (2020-04-17)
Features
Bug Fixes
This PR was generated with Release Please.