Add support for buffer configuration. #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinchoz49
changed the title
tinchoz49
force-pushed
the
tinchoz49-support-for-buffer-configuration
branch
from
681dc13 to
3dd409e
Compare
|
@tinchoz49 Can you please fix the CI? Thanks! |
tinchoz49
force-pushed
the
tinchoz49-support-for-buffer-configuration
branch
from
7d8b2aa to
f4087ec
Compare
|
Fixed |
|
Will fix: #1239 |
|
Any update on this? Great lib by the way! |
jamiees2
added a commit
to jamiees2/protobuf.js
that referenced
this pull request
Oct 20, 2019
|
@alexander-fenster we're depending currently on this fork -- is it likely to get merged soon? Thanks very much. |
alexander-fenster
approved these changes
Nov 21, 2019
|
Folks any chance you can create a new npm release for this: |
bcoe
added a commit
that referenced
this pull request
Mar 11, 2020
bcoe
added a commit
that referenced
this pull request
Mar 11, 2020
pgherveou
pushed a commit
to pgherveou/protobuf.js
that referenced
this pull request
Mar 28, 2020
* Added support for buffer configuration. * Fixed tests for node 4. * Fixed deprecated Buffer methods.
taylorcode
pushed a commit
to taylorcode/protobuf.js
that referenced
this pull request
Oct 16, 2020
* Added support for buffer configuration. * Fixed tests for node 4. * Fixed deprecated Buffer methods.
renawolford6
added a commit
to renawolford6/protobuf-script-build-javascript
that referenced
this pull request
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone!
Description
This PR add support for configuring dynamically a Buffer util.
Similar to what you can do with the util.Long: https://github.com/protobufjs/protobuf.js#browserify-integration
Background
There is a lot of Node.js modules that only works with the Node Buffer implementation but also we can use it in the browser thanks to the feross/buffer.
Many bundle tools like Webpack, Browserify and Parcel already includes a node built-in Buffer implementation and we can use it in protobufjs to encode/decode bytes in similar structures (Buffer) between Node and the browser.