Change order for how FileDescriptors are returned in reflection service. #153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileDescriptors should be returned with the service first and then all dependencies after. All dependencies should occur after a FileDescriptor.
See service reflection: include transitive closure for a file grpc/grpc-go#2949
The Java implementation of the reflection service includes the entire transitive closure for a request file, in toplogical order such that a file's dependencies always appear after the file (so the requested file is first, with all of its dependencies after it).
Fixes Issues with server reflection for code-first #141 once again 😄
// cc @mgravell @ChristianWeyer
Example using
grpcurl
with @ChristianWeyer's blazor app (https://github.com/thinktecture/blazor-webassembly-demo)