Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add freezepanes fix styleid #69

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rwacross
Copy link

@rwacross rwacross commented May 9, 2017

Added code to read out frozen panes from an xlsx and store in !freeze (as opposed to !merge etc.)

Added code to handle a self closing font bracket produced by Google Sheets xlsx exporter. This was causing styleIds to be incorrect.

@pietersv
Copy link
Collaborator

@rwacross
Thanks! The way the root SheetJS/js-xlsx library is architected, it generates xlsx.js by catenating the files in the bits/*.js directory when running make. Can you make the change to the corresponding files under /bits/?

I'm looking for that section of code, and am wondering if this change applies to this repo (protobi/js-xlsx) or to a different fork (spin-io/js-xlsx)? It looks like the spin-io branch has significant enhancements over this branch.

@rwacross
Copy link
Author

rwacross commented Jun 16, 2017

Hi @pietersv ,

I wrote the changes mainly to handle freezes in Google sheets data which was required for a side project. I believe the edits to the /bits/ version are in the first commit shown "(fix)" - after I noticed they were only in the concatenated version - under bits/47_styxml.js and bits/67_wsxml.js.

I'm not working on that project anymore, so I can't comment on further edits made afterwards, but the changes cleared up a lot of style mismatching and formatting issues.

Also, to clear that up, code was from this repo, and those were the only changes until I stopped working on it at the beginning of June.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants