Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify resume streaming function #295

Merged
merged 2 commits into from
Oct 4, 2017
Merged

Modify resume streaming function #295

merged 2 commits into from
Oct 4, 2017

Conversation

gyeongchan-yun
Copy link
Collaborator

What's this PR do?

  1. handle when stored data is empty (null) in resumeDrawing()
  2. add 'resumeIntervalIdentifier' to set resume interval only one time when chart resumes to draw at first

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Thank you! ❤️

🚀

@jorgeyp jorgeyp merged commit db99998 into development Oct 4, 2017
@jorgeyp jorgeyp deleted the streaming branch October 4, 2017 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeyp jorgeyp jorgeyp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gyeongchan-yun @jorgeyp