Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable UMD as a temporary fix #289

Merged
merged 1 commit into from
Sep 27, 2017
Merged

Disable UMD as a temporary fix #289

merged 1 commit into from
Sep 27, 2017

Conversation

jorgeyp
Copy link
Collaborator

@jorgeyp jorgeyp commented Sep 27, 2017

What's this PR do?

Removes output.libraryTarget: 'umd' from the Webpack configuration since this causes an error in the dist file. Will investigate further later.

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)


Thank you! ❤️

🚀

@jorgeyp jorgeyp merged commit 6425401 into development Sep 27, 2017
@jorgeyp jorgeyp deleted the umd-disable-fix branch September 27, 2017 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants