(wrong-number-of-arguments (1 . 2) 8) #50

wakamenod · 2022-11-27T01:34:13Z

Hi, thanks for the great package.

I have a question about this error:

Debugger entered--Lisp error: (wrong-number-of-arguments (1 . 2) 8)
  #f(compiled-function (theme &optional doc) "Declare THEME to be a Custom theme.\nThe optional argument DOC is a doc string describing the theme.\n\nAny theme `foo' should be defined in a file called `foo-theme.el';\nsee `custom-make-theme-feature' for more information." #<bytecode 0x45107dcedbeed62>)(modus-operandi "Elegant, highly legible and customizable light the..." :background-mode 'light :kind 'color-scheme :family 'modus)
  (deftheme modus-operandi "Elegant, highly legible and customizable light the..." :background-mode 'light :kind 'color-scheme :family 'modus)
  (progn (unless (and (fboundp 'require-theme) load-file-name (equal (file-name-directory load-file-name) (expand-file-name "themes/" data-directory)) (require-theme 'modus-themes t)) (require 'modus-themes)) (deftheme modus-operandi "Elegant, highly legible and customizable light the..." :background-mode 'light :kind 'color-scheme :family 'modus) (modus-themes-theme modus-operandi) (provide-theme 'modus-operandi))
  eval((progn (unless (and (fboundp 'require-theme) load-file-name (equal (file-name-directory load-file-name) (expand-file-name "themes/" data-directory)) (require-theme 'modus-themes t)) (require 'modus-themes)) (deftheme modus-operandi "Elegant, highly legible and customizable light the..." :background-mode 'light :kind 'color-scheme :family 'modus) (modus-themes-theme modus-operandi) (provide-theme 'modus-operandi)) t)
  #f(compiled-function (&rest body) "Like `progn', but evaluates the body at compile time and at load time.\nIn interpreted code, this is entirely equivalent to `progn',\nexcept that the value of the expression may be (but is not\nnecessarily) computed at load time if eager macro expansion is\nenabled." #<bytecode 0x28f163835163fd9>)((unless (and (fboundp 'require-theme) load-file-name (equal (file-name-directory load-file-name) (expand-file-name "themes/" data-directory)) (require-theme 'modus-themes t)) (require 'modus-themes)) (deftheme modus-operandi "Elegant, highly legible and customizable light the..." :background-mode 'light :kind 'color-scheme :family 'modus) (modus-themes-theme modus-operandi) (provide-theme 'modus-operandi))
  (eval-and-compile (unless (and (fboundp 'require-theme) load-file-name (equal (file-name-directory load-file-name) (expand-file-name "themes/" data-directory)) (require-theme 'modus-themes t)) (require 'modus-themes)) (deftheme modus-operandi "Elegant, highly legible and customizable light the..." :background-mode 'light :kind 'color-scheme :family 'modus) (modus-themes-theme modus-operandi) (provide-theme 'modus-operandi))

which I encountered when I load the package.
Is there anything I can do to prevent this error?

Emacs Version

GNU Emacs 29.0.50 (build 1, x86_64-w64-mingw32)

OS

Windows 10

modus-them version

modus-themes-20221121.301

init.el

(use-package modus-themes
  :ensure
  :init
  ;; Add all your customizations prior to loading the themes
  (setq modus-themes-italic-constructs t
        modus-themes-bold-constructs nil
        modus-themes-region '(bg-only no-extend))

  ;; Load the theme files before enabling a theme
  (modus-themes-load-themes)
  :config
  ;; Load the theme of your choice:
  (modus-themes-load-vivendi) ;; OR (modus-themes-load-operandi)
  :bind ("<f5>" . modus-themes-toggle))

Others

Possibly related to this commit.

Thanks in advance.

The text was updated successfully, but these errors were encountered:

protesilaos · 2022-11-27T03:33:34Z

Hello @wakamenod!

Can you please delete the .elc files of the themes in your elpa directory and then re-install the package?

wakamenod · 2022-11-27T05:40:59Z

@protesilaos
Thanks for the reply!

I tired this:

M-x find-file ~/.emacs.d/elpa/modus-themes-20221121.301
delete modus-themes.elc
M-x package-reinstall modus-themes

And then this error messages are written in Compile-Log buffer:


Compiling internal form(s) at Sun Nov 27 14:33:43 2022
Leaving directory ‘c:/Users/wakamenod/.emacs.d/elpa/modus-themes-20221121.301’

Compiling file c:/Users/wakamenod/.emacs.d/elpa/modus-themes-20221121.301/modus-operandi-theme.el at Sun Nov 27 14:33:43 2022
Entering directory ‘c:/Users/wakamenod/.emacs.d/elpa/modus-themes-20221121.301/’
modus-operandi-theme.el:55:1: Error: Wrong number of arguments: (1 . 2), 8

Compiling file c:/Users/wakamenod/.emacs.d/elpa/modus-themes-20221121.301/modus-themes.el at Sun Nov 27 14:33:43 2022

Compiling file c:/Users/wakamenod/.emacs.d/elpa/modus-themes-20221121.301/modus-vivendi-theme.el at Sun Nov 27 14:33:43 2022
modus-vivendi-theme.el:55:1: Error: Wrong number of arguments: (1 . 2), 8

protesilaos · 2022-11-27T05:48:20Z

Thanks for the reply!

You are welcome!

delete modus-themes.elc

Sorry for not clarifying this point: please delete all the .elc files. Those that remained are causing the trouble.

wakamenod · 2022-11-27T06:18:15Z

Sorry, I was not sure about all the .elc files you meant.
So I deleted entire elpa directory, and re-install every packages, but still the same problem persists.

protesilaos · 2022-11-27T06:19:50Z

I see. Is your Emacs 29 a recent build from the Git repository? Perhaps you have an older version which does not include the changes that were made to deftheme.

On my end, re-installing the themes does not produce any error.

wakamenod · 2022-11-27T06:27:44Z

My Emacs version is GNU Emacs 29.0.50.

Although I didn't search what the latest version is,
I guess it's little behind from the latest 29, and that must be the catch.

Will upgrade my Emacs and try again !!

Thanks for the help, really appreciated it.

protesilaos · 2022-11-27T06:34:39Z

Very well! If you do M-x emacs-version it will mention the date it was built. This gives us a rough idea. There is a way to find the exact commit by checking the value of emacs-repository-version.

wakamenod · 2022-11-27T06:43:13Z

If you do M-x emacs-version it will mention the date it was built.

Actually this gives me GNU Emacs 29.0.50 (build 1, x86_64-w64-mingw32) 🤔

There is a way to find the exact commit by checking the value of emacs-repository-version.

Oh, never knew that!

emacs-repository-version is a variable defined in version.el.

Value
"48d1e6e9d9217918b68daac9b23140bf8e36c2bf

Also...

emacs-repository-branch is a variable defined in version.el.

Value
"master"

protesilaos · 2022-11-27T07:01:35Z

Okay, I see that the commit you are using is fairly old:

commit 48d1e6e9d9217918b68daac9b23140bf8e36c2bf
Merge: 8ff1a9d00bf f38dfa56a0c
Author: Stefan Kangas <[email protected]>
Date:   Thu Dec 2 17:34:10 2021 +0100

    Merge from origin/emacs-28
    
    f38dfa56a0 ; Update loaddefs files.
    b3d4b18507 ; make change-history-commit
    334ff0232e * lisp/repeat.el: Use same logic for repeat-check-key and ...
    8230a47ecc * lisp/help.el (help--analyze-key): Prefer posn-set-point ...
    
    # Conflicts:
    #       lisp/ldefs-boot.el

If you can rebuild Emacs with a recent commit, the issue will most likely be resolved.

wakamenod · 2022-11-27T07:05:09Z

@protesilaos
You are right i"m far behind from the latest....
Sorry my bad...

Closing this issue.

protesilaos · 2022-11-27T07:10:36Z

No worries! Though do tell me if a newer version actually fixes things.

wakamenod · 2022-11-27T07:38:23Z

@protesilaos

Fix confirmed with the revision cdb1080ec38dd0f05130c923eee25a2329f57012

Sorry about all the fuss I made 😢

Thanks very much for your help.

protesilaos · 2022-11-27T09:23:50Z

You are welcome!

This reverts commit f1cf9a1. The report in issue 50 on the GitHub mirror made me think that we should not do this as it is backward incompatible: <#50>. Besides, the files already include theme properties in a different way, per commit 5fee337.

This is for wakamenod's report on the GitHub mirror about the bug caused by commit f1cf9a1: <#50>. I have since reverted the offending commit.

wakamenod closed this as completed Nov 27, 2022

protesilaos added a commit that referenced this issue Nov 27, 2022

Update the manual's acknowledgements

dd64df9

This is for wakamenod's report on the GitHub mirror about the bug caused by commit f1cf9a1: <#50>. I have since reverted the offending commit.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(wrong-number-of-arguments (1 . 2) 8) #50

(wrong-number-of-arguments (1 . 2) 8) #50

wakamenod commented Nov 27, 2022 •

edited

Loading

protesilaos commented Nov 27, 2022

wakamenod commented Nov 27, 2022

protesilaos commented Nov 27, 2022

wakamenod commented Nov 27, 2022

protesilaos commented Nov 27, 2022

wakamenod commented Nov 27, 2022 •

edited

Loading

protesilaos commented Nov 27, 2022

wakamenod commented Nov 27, 2022

protesilaos commented Nov 27, 2022

wakamenod commented Nov 27, 2022

protesilaos commented Nov 27, 2022

wakamenod commented Nov 27, 2022

protesilaos commented Nov 27, 2022

(wrong-number-of-arguments (1 . 2) 8) #50

(wrong-number-of-arguments (1 . 2) 8) #50

Comments

wakamenod commented Nov 27, 2022 • edited Loading

Emacs Version

OS

modus-them version

init.el

Others

protesilaos commented Nov 27, 2022

wakamenod commented Nov 27, 2022

protesilaos commented Nov 27, 2022

wakamenod commented Nov 27, 2022

protesilaos commented Nov 27, 2022

wakamenod commented Nov 27, 2022 • edited Loading

protesilaos commented Nov 27, 2022

wakamenod commented Nov 27, 2022

protesilaos commented Nov 27, 2022

wakamenod commented Nov 27, 2022

protesilaos commented Nov 27, 2022

wakamenod commented Nov 27, 2022

protesilaos commented Nov 27, 2022

wakamenod commented Nov 27, 2022 •

edited

Loading

wakamenod commented Nov 27, 2022 •

edited

Loading