total WIP of adding ipv4 defrag #22
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still messing around with this. Reading https://tools.ietf.org/html/rfc815 this may be a bit more complicated than what is expressed in this MR. |
…d be able to take the payloads in order. Right now, I have 2 components: 1 the hole checker, and the other is a btreemap of that will allow us to read packets in order once we know no gaps exist. Perhaps these could be combined, but to make testing easier for now they are seperate.
…e in case of fragments
|
Thinking we need to pass a FlowParsingContext, this context could dictate if ip fragmentation happens, and allow for state of fragmentation buffers to be stored. Also, could like to make fragmentation more generic if possible, however more research is needed on ipv6 fragmentation. |
|
@kornstar11 there is no fragmentation on IPv6. This is only for IPv4. On IPv6 they removed fragmentation and let the application or higher protocols (TCP) do any fragmentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work to add a ipv4 defrag component to capture ipv4 packets, and when ready to reassemble it should hand back the reassembled payload.