Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on deprecated oldest-supported-numpy #194

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mathiasburger
Copy link

Change Description

Remove dependency on the deprecated oldest-supported-numpy. They state that it is not necessary to use that package anymore since numpy 1.25. To my understanding, the dependency would only be required as build-time-dependency and not as a runtime dependency.

References:

Issue reference

The dependency breaks resolution for artifacts requiring a higher version of numpy:

File "/opt/python/versions/3.11.10/lib/python3.11/site-packages/resolvelib/resolvers.py", line 318, in _backjump raise ResolutionImpossible(causes) resolvelib.resolvers.ResolutionImpossible: [RequirementInformation(requirement=<Requirement('numpy==1.26.4; python_version >= "3.11" and python_version < "3.12"')>, parent=None), ..., RequirementInformation(requirement=<Requirement('numpy==1.23.2; python_version == "3.11" and platform_python_implementation != "PyPy"')>, parent=Candidate(name='oldest-supported-numpy', version=<Version('2022.11.19')>, extras=set()))]

Checklist

  • [/] I have reviewed the contribution guidelines
  • [/] My code includes unit tests
  • [/] All unit tests and lint checks pass locally
  • [/] My PR contains documentation updates / additions if required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants