Detect target file encoding in autodetect.py #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes issue #65. Infer the target python source file encoding before attempting to parse it for imports of interest. - First, using byte order markers (BOM). An example of this was found in ``setuptools/tests/script-with-bom.py``. - Secondly, using PEP263 regular expression over the first two lines -- only if they begin with a comment (#), decoded as utf8, to determine if it has a source file encoding, by seeking statements such as ``# coding: latin1``. - Finally, default to utf8. If the target file fails to decode, or the given codec is not found -- issue a warning and move on to the next file.
carlio
added a commit
that referenced
this pull request
Dec 5, 2014
Detect target file encoding in autodetect.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #65. Infer the target python source file encoding before attempting to parse it for imports of interest (such as django).
this was found in
setuptools/tests/script-with-bom.py.two lines -- only if they begin with a comment (#), decoded
as utf8, to determine if it has a source file encoding,
by seeking statements such as
# coding: latin1.or the given codec is not found -- issue a warning and move
on to the next file.