Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React bindings sketch #72

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -82,5 +82,17 @@
"volta": {
"node": "20.12.2",
"pnpm": "9.0.5"
},
"pnpm": {
"patchedDependencies": {
"[email protected]": "patches/[email protected]"
}
},
"dependencies": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these all be dev dependencies instead?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ye

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually -- should all of these move to the react sub-project? and not in the main utils package?
(I just saw that the main package has no changes)

"@testing-library/jest-dom": "^6.4.6",
"@testing-library/react": "^16.0.0",
"@testing-library/user-event": "^14.5.2",
"@vitejs/plugin-react": "^4.3.1",
"react": "^18.3.1"
}
}
78 changes: 78 additions & 0 deletions patches/[email protected]
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
diff --git a/dist/index.js b/dist/index.js
index ac1ae216236d55b0a31ca78915f45997b32a5e8b..9edf329d851e0c294cc6e1c9c9f21f934e646c43 100644
--- a/dist/index.js
+++ b/dist/index.js
@@ -81,7 +81,11 @@ function L(r) {
function nr() {
A++;
}
-function H(r) {
+function H(r, shouldForceRecompute) {
+ if (shouldForceRecompute) {
+ r.producerRecomputeValue(r), r.dirty = !1, r.lastCleanEpoch = A;
+ return
+ }
if (!(D(r) && !r.dirty) && !(!r.dirty && r.lastCleanEpoch === A)) {
if (!r.producerMustRecompute(r) && !fr(r)) {
r.dirty = !1, r.lastCleanEpoch = A;
@@ -171,8 +175,8 @@ function j(r) {
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.io/license
*/
-function Q(r) {
- if (H(r), L(r), r.value === W)
+function Q(r, shouldForceRecompute = false) {
+ if (H(r, shouldForceRecompute), L(r), r.value === W)
throw r.error;
return r.value;
}
@@ -318,12 +322,25 @@ var B;
m && (p.equal = m), p.watched = f[r.subtle.watched], p.unwatched = f[r.subtle.unwatched];
}
}
- get() {
+ get(shouldForceRecompute = false) {
if (!v(this))
throw new TypeError(
"Wrong receiver type for Signal.Computed.prototype.get"
);
- return Q(this[s]);
+ return Q(this[s], shouldForceRecompute);
+ }
+ isPending() {
+ const node = this[s];
+ r.subtle.introspectSources(this).map((s) => s.get());
+ if (!node.producerNode?.length) return false
+
+ for (let len= node.producerNode.length, i = 0; i < len; i++) {
+ debugger
+ if (node.producerNode[i].version !== node.producerLastReadVersion[i]) {
+ return true
+ }
+ }
+ return false
}
}
X = s, S = new WeakSet(), Sr = function() {
@@ -436,6 +453,7 @@ var B;
d.currentComputed = Z, d.watched = Symbol("watched"), d.unwatched = Symbol("unwatched");
})(r.subtle || (r.subtle = {}));
})(B || (B = {}));
+
export {
B as Signal
};
diff --git a/dist/wrapper.d.ts b/dist/wrapper.d.ts
index 8c96d454dc46f9cd069e73325c125eb576f495d5..15beddda67c5f582ab50dbd7a05ce35b9fb6dd36 100644
--- a/dist/wrapper.d.ts
+++ b/dist/wrapper.d.ts
@@ -15,7 +15,8 @@ export declare namespace Signal {
#private;
readonly [NODE]: ComputedNode<T>;
constructor(computation: () => T, options?: Signal.Options<T>);
- get(): T;
+ get(shouldForceRecompute?: boolean): T;
+ isPending(): boolean;
}
type AnySignal<T = any> = State<T> | Computed<T>;
type AnySink = Computed<any> | subtle.Watcher;
Loading