-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React bindings sketch #72
Draft
ds300
wants to merge
3
commits into
proposal-signals:main
Choose a base branch
from
ds300:react-bindings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -82,5 +82,17 @@ | |
"volta": { | ||
"node": "20.12.2", | ||
"pnpm": "9.0.5" | ||
}, | ||
"pnpm": { | ||
"patchedDependencies": { | ||
"[email protected]": "patches/[email protected]" | ||
} | ||
}, | ||
"dependencies": { | ||
"@testing-library/jest-dom": "^6.4.6", | ||
"@testing-library/react": "^16.0.0", | ||
"@testing-library/user-event": "^14.5.2", | ||
"@vitejs/plugin-react": "^4.3.1", | ||
"react": "^18.3.1" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
diff --git a/dist/index.js b/dist/index.js | ||
index ac1ae216236d55b0a31ca78915f45997b32a5e8b..9edf329d851e0c294cc6e1c9c9f21f934e646c43 100644 | ||
--- a/dist/index.js | ||
+++ b/dist/index.js | ||
@@ -81,7 +81,11 @@ function L(r) { | ||
function nr() { | ||
A++; | ||
} | ||
-function H(r) { | ||
+function H(r, shouldForceRecompute) { | ||
+ if (shouldForceRecompute) { | ||
+ r.producerRecomputeValue(r), r.dirty = !1, r.lastCleanEpoch = A; | ||
+ return | ||
+ } | ||
if (!(D(r) && !r.dirty) && !(!r.dirty && r.lastCleanEpoch === A)) { | ||
if (!r.producerMustRecompute(r) && !fr(r)) { | ||
r.dirty = !1, r.lastCleanEpoch = A; | ||
@@ -171,8 +175,8 @@ function j(r) { | ||
* Use of this source code is governed by an MIT-style license that can be | ||
* found in the LICENSE file at https://angular.io/license | ||
*/ | ||
-function Q(r) { | ||
- if (H(r), L(r), r.value === W) | ||
+function Q(r, shouldForceRecompute = false) { | ||
+ if (H(r, shouldForceRecompute), L(r), r.value === W) | ||
throw r.error; | ||
return r.value; | ||
} | ||
@@ -318,12 +322,25 @@ var B; | ||
m && (p.equal = m), p.watched = f[r.subtle.watched], p.unwatched = f[r.subtle.unwatched]; | ||
} | ||
} | ||
- get() { | ||
+ get(shouldForceRecompute = false) { | ||
if (!v(this)) | ||
throw new TypeError( | ||
"Wrong receiver type for Signal.Computed.prototype.get" | ||
); | ||
- return Q(this[s]); | ||
+ return Q(this[s], shouldForceRecompute); | ||
+ } | ||
+ isPending() { | ||
+ const node = this[s]; | ||
+ r.subtle.introspectSources(this).map((s) => s.get()); | ||
+ if (!node.producerNode?.length) return false | ||
+ | ||
+ for (let len= node.producerNode.length, i = 0; i < len; i++) { | ||
+ debugger | ||
+ if (node.producerNode[i].version !== node.producerLastReadVersion[i]) { | ||
+ return true | ||
+ } | ||
+ } | ||
+ return false | ||
} | ||
} | ||
X = s, S = new WeakSet(), Sr = function() { | ||
@@ -436,6 +453,7 @@ var B; | ||
d.currentComputed = Z, d.watched = Symbol("watched"), d.unwatched = Symbol("unwatched"); | ||
})(r.subtle || (r.subtle = {})); | ||
})(B || (B = {})); | ||
+ | ||
export { | ||
B as Signal | ||
}; | ||
diff --git a/dist/wrapper.d.ts b/dist/wrapper.d.ts | ||
index 8c96d454dc46f9cd069e73325c125eb576f495d5..15beddda67c5f582ab50dbd7a05ce35b9fb6dd36 100644 | ||
--- a/dist/wrapper.d.ts | ||
+++ b/dist/wrapper.d.ts | ||
@@ -15,7 +15,8 @@ export declare namespace Signal { | ||
#private; | ||
readonly [NODE]: ComputedNode<T>; | ||
constructor(computation: () => T, options?: Signal.Options<T>); | ||
- get(): T; | ||
+ get(shouldForceRecompute?: boolean): T; | ||
+ isPending(): boolean; | ||
} | ||
type AnySignal<T = any> = State<T> | Computed<T>; | ||
type AnySink = Computed<any> | subtle.Watcher; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these all be dev dependencies instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ye
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually -- should all of these move to the react sub-project? and not in the main utils package?
(I just saw that the main package has no changes)