Benchmarks from js-reactivity-benchmark in CI #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divdavem
force-pushed
the
benchmarks
branch
2 times, most recently
from
fa0cef5 to
3f1165c
Compare
|
I think this PR is ready to be reviewed. Note that the CI fails currently because there is no gh-pages branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussing today with @NullVoxPopuli during the community call, I am opening this PR to add benchmarks to the CI of this repository.
This PR is inspired from similar PRs (here and there) that we did on tansu (our own signal implementation).
It uses the benchmark-action/github-action-benchmark action. For this to work, a gh-pages branch must exist in the repository. The action will publish benchmarks on the gh-pages branch, with graphs (cf an example here). It will also compare benchmarks of a PR with the main branch (cf here).