Skip to content
This repository has been archived by the owner on May 21, 2018. It is now read-only.

[WIP] Move JSON/XML modules to separate projects #261

Closed
wants to merge 6 commits into from

Conversation

mielientiev
Copy link
Collaborator

@mielientiev mielientiev commented Jan 28, 2017

The main goal of this PR is to move JSON/XML modules to separate projects.

Copy link
Owner

@propensive propensive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, regarding all the "new" code that is added, is that simply copy/pasted from rapture.data, then fixed to correct references to rapture.data?

I'm assuming that the deletions of the original files will be made after you've done the same thing with Rapture XML...

Anyhow, it looks good to continue now! Let me know if you need any help/explanations.

case (t, p1 :: Nil) =>
s"parameter `$p1' of type $t"
case (t, p1 :: ps) =>
s"parameters ${ps.map(v => s"`$v'").mkString(", ")} and `$p1' of type $t"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this red marking just GitHub's parser getting confused?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. All code compiles and tests passes

@mielientiev
Copy link
Collaborator Author

@propensive Yep. For now, it's just copy-pasting from data module to json/xml module.
In future, all json/xml modules will only depend on rapture-core.
after I've done the same thing with Rapture XML, we can move Rapture JSON & XML to the separate repos

@propensive
Copy link
Owner

I'm going to tidy up Rapture, and keep track of this in Xylophone from now on.

@propensive propensive closed this Jan 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants