-
Notifications
You must be signed in to change notification settings - Fork 39
[WIP] Move JSON/XML modules to separate projects #261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm, regarding all the "new" code that is added, is that simply copy/pasted from rapture.data
, then fixed to correct references to rapture.data
?
I'm assuming that the deletions of the original files will be made after you've done the same thing with Rapture XML...
Anyhow, it looks good to continue now! Let me know if you need any help/explanations.
case (t, p1 :: Nil) => | ||
s"parameter `$p1' of type $t" | ||
case (t, p1 :: ps) => | ||
s"parameters ${ps.map(v => s"`$v'").mkString(", ")} and `$p1' of type $t" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this red marking just GitHub's parser getting confused?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so. All code compiles and tests passes
@propensive Yep. For now, it's just copy-pasting from data module to json/xml module. |
I'm going to tidy up Rapture, and keep track of this in Xylophone from now on. |
The main goal of this PR is to move JSON/XML modules to separate projects.