phpstan: column with whitespace-only size spec

[smhg]

@gechetspr this fixes the single phpstan error about the condition always being true. It has been adressed as an add-on in other pull requests, but I think it makes sense to handle this in a dedicated PR so CI improves for everyone.

However (this is pushing the limits of my PHP/regex knowledge): I think phpstan might actually be wrong here?
My reasoning: the function uses a regex on the column definition (e.g. VARCHAR (25)). The second match of the regex refers to anything between the brackets (column size). I think, because of the comments inside the regex, phpstan detects there will always be at least one space between the brackets. In that case the if statement is indeed always true.
But the regex contains an /x modifier, which ignores those whitespaces, no?

@staabm would you be able to chime in on what's happening here?

Edit: FWIW the other failing (mysql) tests is addressed separately in #2021.

[gharlan]

There seems to be an issue with regex comments in phpstan (with /x modifier).
https://phpstan.org/r/5616feb8-13fb-4e32-8f8c-c92656da3d7e
When removing the # ( comments, the issue is gone.

[smhg]

Thank you @gharlan. I've reverted the change and made phpstan ignore the error.

[gharlan]

phpstan/phpstan#12242

[staabm]

fixed via phpstan/phpstan-src#3735