Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEHAVIOR] Add ability to choose between DATETIME and TIMESTAMP #1978

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

wollanup
Copy link
Contributor

Closes #1971

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4f36eea) 89.27% compared to head (85745f9) 89.27%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1978   +/-   ##
=========================================
  Coverage     89.27%   89.27%           
- Complexity     8049     8052    +3     
=========================================
  Files           232      232           
  Lines         24519    24521    +2     
=========================================
+ Hits          21889    21891    +2     
  Misses         2630     2630           
Flag Coverage Δ
5-max 89.27% <100.00%> (+<0.01%) ⬆️
7.4 89.27% <100.00%> (+<0.01%) ⬆️
agnostic 67.47% <100.00%> (+<0.01%) ⬆️
mysql 69.84% <100.00%> (+0.03%) ⬆️
pgsql 69.87% <100.00%> (+0.03%) ⬆️
sqlite 67.81% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...r/Behavior/Timestampable/TimestampableBehavior.php 95.94% <100.00%> (+0.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wollanup
Copy link
Contributor Author

wollanup commented Sep 18, 2023

Hi @michbeck and @dereuromark !
If you're interested by this PR, could you help me with the tests errors (8.2, pgsql) please ?
I'm not sure to find the cause easily. Maybe a problem saving a book [here] ?(

$this->createBook($author3, 1);
)

Thanks for any help !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants