add reopen todo #59
add reopen todo #59
Conversation
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| * | ||
| * Date: 5/2/15 - 5:50 PM |
|
Also some php-cs issues, see travis build. |
| */ | ||
| public function onTodoWasReopened(TodoWasReopened $event) | ||
| { | ||
| $user = $this->userFinder->findUserOfTodo($event->todoId()->toString()); |
There was a problem hiding this comment.
@basz I don't think that this is needed.
/cc @codeliner thougts?
There was a problem hiding this comment.
all methods of the UserProjector look like the new one added by @basz
So I'd say it is ok for the exercise but we should think about refactoring it.
Unfortunately, I cannot remember why assignee_id is not part of the events. However, this would be a better approach as an event should contain all data required to populate the read model. If we add the assignee_id to the events we can remove the UserFinder dependency and the exception if user cannot be found. It is task of the domain to protect invariants, so the user must exist if referenced in an event.
There was a problem hiding this comment.
most things were a copy of the TodoWasMarkedAsDone behaviour, that's my excuse here... ;-p
It is task of the domain to protect invariants
sounds sane
|
excellent work @basz |
exersize #2