feat(sentinel-lib): Add support to generic event signing #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of `UserOps`
…ould be handled w/r/t `SignedEvents`
NOTE: This is my final commit to pNetwork - it's been a pleasure working with you all over the years! <3
…from the `SignedEvents` type
envin3
reviewed
May 17, 2024
| fn encode(&self) -> Bytes { | ||
| // FIXME sha256(protocol, protocol_chain_id, blockhash, unique_event_identifier_such_as_merklepathonevm) | ||
| // Currently, random 32 bytes | ||
| let event_id = &[0xab, 0xcd, 0xee, 0xff]; |
envin3
reviewed
May 17, 2024
| let receipt = sub_mat.receipts[0].clone(); | ||
| let (tx_index, _) = receipt.get_rlp_encoded_index_and_rlp_encoded_receipt_tuple().unwrap(); | ||
| let proof = MerkleProof::try_from((&mut merkle_tree, tx_index.as_ref())).unwrap(); | ||
| // FIXME type mismatch |
There was a problem hiding this comment.
ok as discussed. To be fixed in a next release.
ubordignon
force-pushed
the
sentinel-generic-event-signing
branch
from
cce6661 to
e1d7b70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.