Consistent IDs for POD PCDs, to prevent multiple insert of otherwise-… #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this, though to avoid breaking any use cases which want duplicates, I'd suggest making this an option to the developer. |
saurfang
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
I can't think of any use case that one would want duplicate POD because they are non-addressable in the current Z API interface (i.e. signature is used as the UUID for the most part) I'm supportive of this change to unblock a bug that we saw in the wild, where user ends up 100s duplicate PODs and crashing frogcrypto. We don't know how to reproduce this bug yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…identical POD