New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spectator ready up #11

Closed

kristiandz wants to merge 1 commit into promod:master from kristiandz:readyup

kristiandz commented Mar 26, 2020

Spectators will not get flaged for not ready.

Tested locally alone, should be tested more on other match modes and with more players, but it shoud work like this.

If player's team is "spectator" he will get flaged as ready
Checking are there 2 players before allowing the ready flag to prevent a possible scenario where a first player in the match joins and enteres spectators so he won't start the match.


          Spectator ready up

7cb1679

Spectators will not get flaged for not ready.

kristiandz mentioned this pull request

Automatic Ready-Up for Spectators #5

Open

Contributor

Trivve commented Mar 26, 2020

Hi, I tested this quickly and it doesn't work too well.

Demo menu will just keep opening indefinitely until match starts (enabled or not)
Match can start when demo menu is open (for other spec)
Last player ready up notification will fire when it shouldn't

But don't worry about it. I will push my rewrite of ready up code soon.

Thanks for the effort tho.

Trivve closed this

kristiandz deleted the readyup branch

September 8, 2021 07:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet