-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New intro, and other textual revisions #117
Conversation
So uh any general comments? Shall we merge? |
Haven't had time to look it over thoroughly yet. I'll have time on Monday. |
- Move `promise1 !== promise2` non-requirement to "Omissions" from "Additions". - Add `onFulfilled` and `onRejected` called as functions requirement (new in 1.1) to "Additions". - Change "returns a promise" to "returns a thenable", and expand upon what has been added (i.e. the resolution procedure). - Use "reason" instead of "rejection reason". - Rewrite the "Clarifications" section for better structure and clarity. - Add "thenable" to the list of things we clarify.
Comments addressed and new revisions force-pushed. |
If there's no objections over the next day or so, I think I'll merge this. |
I will look at this quickly tomorrow evening. |
Helpful link for easier browsing: https://github.com/promises-aplus/promises-spec/tree/556f02ae249c3b4edd8fae760743857b85728481 |
Thanks, very helpful |
I was having a nice discussion related to the promise topic, I remembered the intro as "A promise represents a value that may not be available yet", thought of coming here and propose to change that to something about "operations" and you had already changed it. 👍 |
lgtm. Merging since there haven't been any other objections or suggestions. |
New intro, and other textual revisions
Woo.