-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag 1.0.0 #56
Comments
👍 The only minor nit I see is 3.2.5.1 and 3.2.5.2 starting with "if". Changing it to "if/when" or "in the fulfilled state" may be better. |
👍 |
👍 One non-content related nit: the gh-pages version of the doc numbers the footnotes as 4.1, 4.2, and 4.3, which doesn't match the links to those footnotes. |
👍 agree on nits. |
@lsmith great catch! I'll fix these nits shortly. |
Hmmm, anyone know what's up with 3.1.1?? Why is the sub-bullet not actually a sub-bullet. Looking at the markdown, it's not obvious what is going wrong--maybe a jekyll/gh-pages problem? |
Nits fixed. If we can figure out the sub-bullet problem, I think we'll be ready. |
Weird. yeah. Even this comment box supports the formatting as written in the README.md RequirementsPromise StatesA promise must be in one of three states: pending, fulfilled, or rejected.
|
It'd also be cool to get a domain name. |
I totally agree about the domain name--that'll be very cool. I think we can go ahead and tag without it, tho. Anyone know how we might get a domain name for free? Figured I'd at least ask :) |
Ok, I found a way to work around the apparent jekyll bullet rendering bug in 3.1.1. If there are no other nits by tomorrow afternoon EST, I'll tag. |
Ok, all, we're 1.0.0 now :) Feel free to tweet it up (although I'll prolly wait for a more optimal tweet time :) ) |
woohoo! I had a beer in celebration last night. |
Quick straw pull: Are we ready for 1.0.0? 👍 or 👎
If 👎 then please list the specific reasons.
The text was updated successfully, but these errors were encountered: