This repository has been archived by the owner on May 3, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
java_proto_library
targets from https://github.com/pubref/rules_protobuf @ v.0.7.1In our
java_binary
target we need only to provide the path to the//proto:c
dependency for compilation / runtime with--strict_java_deps=ERROR
enabled.For a
scala_binary
, I would expect to only need to do the same, but it seems the output of our//proto:c
is providing jars in a way thatjava_library
will pick them up as exports butscala_
will not.Situation is the same as: promiseofcake/bazel-scala-test#2, (Issue: bazelbuild/rules_scala#235) except in this case we don't have control over the target to be able to export all the necessary dependencies.