Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collector for workflow_job events #405

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

marcusramberg
Copy link
Contributor

Adds a webhook and collector for workflow_job, similiar to how the workflow_run collector works.

This is a continuation of the work done in #380.

Copy link
Member

@tboerger tboerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort! I would prefer to keep the empty lines that have been dropped by you.

.gitignore Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
pkg/action/server.go Outdated Show resolved Hide resolved
pkg/store/chai.go Outdated Show resolved Hide resolved
pkg/store/generic_workflow_job.go Outdated Show resolved Hide resolved
@marcusramberg
Copy link
Contributor Author

Thanks for the effort! I would prefer to keep the empty lines that have been dropped by you.

Thanks for the review :) I guess it's my autoformatter that removed them, I'll try to restore them and address your other review comments.

@marcusramberg marcusramberg force-pushed the marcus/workflow_queue_time branch 2 times, most recently from 36b16e0 to b106ffe Compare October 8, 2024 21:04
@marcusramberg marcusramberg requested a review from tboerger October 9, 2024 08:18
@marcusramberg marcusramberg force-pushed the marcus/workflow_queue_time branch from b106ffe to 71ec6dd Compare October 18, 2024 12:54
@tboerger
Copy link
Member

After fixing the linting error I would merge it finally

@marcusramberg marcusramberg force-pushed the marcus/workflow_queue_time branch from 71ec6dd to aba8b5d Compare October 19, 2024 13:11
@tboerger tboerger merged commit 41856bd into promhippie:master Oct 19, 2024
15 checks passed
@marcusramberg marcusramberg deleted the marcus/workflow_queue_time branch October 19, 2024 17:55
@tboerger tboerger added this to the v3.2.0 milestone Oct 23, 2024
@tboerger tboerger added the enhancement New feature or request label Oct 23, 2024
@tboerger tboerger modified the milestones: v3.2.0, v4.0.0 Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants