Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow comments in mapping files #70

Merged
merged 1 commit into from
May 24, 2017
Merged

Conversation

jasonmoo
Copy link
Contributor

Hi. This is handy and missing. Hope it is acceptable @juliusv.

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ SuperQ requested a review from juliusv May 24, 2017 05:42
@juliusv
Copy link
Member

juliusv commented May 24, 2017

👍 Thanks. Even better would be to also allow comments at the end of other lines, but it's ok for now I think.

@juliusv juliusv merged commit 20becbc into prometheus:master May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants