Allow custom registry for initialization of collector metrics #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marctc
force-pushed
the
explicit_metrics_registration
branch
from
74e06aa to
d21c801
Compare
|
cc @SuperQ |
marctc
force-pushed
the
explicit_metrics_registration
branch
from
cbd7b0c to
e9f2286
Compare
marctc
changed the title
Signed-off-by: Marc Tuduri <[email protected]>
Signed-off-by: Marc Tuduri <[email protected]>
Signed-off-by: Marc Tuduri <[email protected]>
marctc
force-pushed
the
explicit_metrics_registration
branch
from
e9f2286 to
595a6a3
Compare
SuperQ
approved these changes
Jun 23, 2023
SuperQ
changed the title
SuperQ
pushed a commit
that referenced
this pull request
Jun 23, 2023
* Explicit registration of collector metrics --------- Signed-off-by: Marc Tuduri <[email protected]>
stephan-windischmann-sky
pushed a commit
to stephan-windischmann-sky/snmp_exporter
that referenced
this pull request
Oct 27, 2023
…heus#885) * Explicit registration of collector metrics --------- Signed-off-by: Marc Tuduri <[email protected]> Signed-off-by: Stephan Windischmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the initialization of SNMP internal metrics allowing to specify a custom registry. This is aims to solve the issue described here but in a generic way. I took a similar approach to this PR to solve the issue.