Remove Eaton from examples #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eaton has made their MIBs incaccessible to our CI. So remove them from the examples. * Also rollback Cisco I'm not sure MIBs due to recent breakage. Signed-off-by: SuperQ <[email protected]>
SuperQ
force-pushed
the
superq/rm_eaton
branch
from
2157aba to
80393dc
Compare
|
FYI, I figured out what was wrong with the upstream Cisco MIBs. I filed a PR to fix them. |
|
perhaps we should wait a bit before merging this PR, just to see if they are going to fix it quickly. Perhaps then this PR won't be required anymore |
|
It's been broken for months, I'm not expecting anything soon. |
Nexucis
approved these changes
Feb 14, 2023
|
Yup, hopefully they fix it eventually. |
This was referenced Feb 14, 2023
Closed
Closed
Merged
stephan-windischmann-sky
pushed a commit
to stephan-windischmann-sky/snmp_exporter
that referenced
this pull request
Oct 27, 2023
Eaton has made their MIBs incaccessible to our CI. So remove them from the examples. * Also rollback Cisco I'm not sure MIBs due to recent breakage. Signed-off-by: SuperQ <[email protected]> Signed-off-by: Stephan Windischmann <[email protected]>
stephan-windischmann-sky
pushed a commit
to stephan-windischmann-sky/snmp_exporter
that referenced
this pull request
Oct 27, 2023
* [FEATURE] Add indices filters prometheus#624 * [FEATURE] Add MIBOPTS flag to the generator prometheus#891 * [ENHANCEMENT] Treat Bits as OctetString prometheus#870 * [ENHANCEMENT] Report duration in logs for canceled scrapes prometheus#876 * [BUGFIX] Fix several generator MIBs. prometheus#843, prometheus#868, prometheus#889 Signed-off-by: SuperQ <[email protected]> Signed-off-by: Stephan Windischmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eaton has made their MIBs incaccessible to our CI. So remove them from the examples.
Signed-off-by: SuperQ [email protected]