Fix retries in generator #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
force-pushed
the
superq/fix_0_retries
branch
from
197ecf5 to
a6f4601
Compare
roidelapluie
approved these changes
Aug 3, 2022
Fix parsing of `0` in retries in the generator config by making the struct value a pointer[0]. Fixes: #785 [0]: https://www.sohamkamani.com/golang/omitempty/#the-difference-between-0--and-nil Signed-off-by: SuperQ <[email protected]>
SuperQ
force-pushed
the
superq/fix_0_retries
branch
from
a6f4601 to
93b866c
Compare
|
this actually seems like a bug in the yaml lib |
|
I agree, it's a very strange behavior of the library. Sadly, we're stuck with yaml.v2 due the new library not having a strict unmarshal. We might consider moving to a different yaml library. |
|
The new library has strict unmarshal. |
SuperQ
added a commit
that referenced
this pull request
Nov 21, 2022
* [CHANGE] Update to exporter-toolkit v0.8.1 (#810) * [FEATURE] Support chained lookups in the generator (#757) * [ENHANCEMENT] Add per-SNMP packet statistics. (#656) * [ENHANCEMENT] Add support for aes192c and aes256c privacy protocol (#657) * [ENHANCEMENT] Support responding from different source address (#702) * [BUGFIX] Fixes dropped context passing (#634) * [BUGFIX] Add version flag (#717) * [BUGFIX] Fix retries in generator (#786) Signed-off-by: SuperQ <[email protected]>
Merged
SuperQ
added a commit
that referenced
this pull request
Nov 21, 2022
* [CHANGE] Update to exporter-toolkit v0.8.1 (#810) * [FEATURE] Support chained lookups in the generator (#757) * [ENHANCEMENT] Add per-SNMP packet statistics. (#656) * [ENHANCEMENT] Add support for aes192c and aes256c privacy protocol (#657) * [ENHANCEMENT] Support responding from different source address (#702) * [BUGFIX] Fixes dropped context passing (#634) * [BUGFIX] Add version flag (#717) * [BUGFIX] Fix retries in generator (#786) Signed-off-by: SuperQ <[email protected]>
SuperQ
added a commit
that referenced
this pull request
Nov 22, 2022
* [CHANGE] Update to exporter-toolkit v0.8.1 (#810) * [FEATURE] Support chained lookups in the generator (#757) * [ENHANCEMENT] Add per-SNMP packet statistics. (#656) * [ENHANCEMENT] Add support for aes192c and aes256c privacy protocol (#657) * [ENHANCEMENT] Support responding from different source address (#702) * [BUGFIX] Fixes dropped context passing (#634) * [BUGFIX] Add version flag (#717) * [BUGFIX] Fix retries in generator (#786) Signed-off-by: SuperQ <[email protected]> Signed-off-by: SuperQ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix parsing of
0in retries in the generator config by making thestruct value a pointer0.
Fixes: #785
Signed-off-by: SuperQ [email protected]