Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to allow out-of-order OIDs #759

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

mjsaarin
Copy link
Contributor

@mjsaarin mjsaarin commented May 17, 2022

Add a configuration option (allow_nonincreasing_oids) to support out-of-order OIDs from devices.

@mjsaarin mjsaarin force-pushed the snmp_exporter-mjs branch from 8b0d00d to 4b4c3b6 Compare May 17, 2022 08:20
@SuperQ
Copy link
Member

SuperQ commented May 17, 2022

This needs a DCO sign-off. You can use git commit -s --amend to add it.

@SuperQ SuperQ changed the title Added a configugration option that instructs GoSNMP to allow a set of… Add option to allow out of order OIDs May 17, 2022
@SuperQ SuperQ changed the title Add option to allow out of order OIDs Add option to allow out-of-order OIDs May 17, 2022
… OIDs that aren't in a strictly increasing order.

Signed-off-by: Matti Saarinen <[email protected]>
@mjsaarin mjsaarin force-pushed the snmp_exporter-mjs branch from 4b4c3b6 to 29f6b6c Compare May 17, 2022 10:20
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ
Copy link
Member

SuperQ commented May 17, 2022

We can add support to the generator separately.

@SuperQ SuperQ merged commit f73fb5e into prometheus:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants