Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override bsnAPName to DisplayString #660

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Override bsnAPName to DisplayString #660

merged 1 commit into from
Sep 18, 2023

Conversation

devon-mar
Copy link
Contributor

This PR overrides bsnAPName to DisplayString in the cisco_wlc module.

Before:

bsnApIfNoOfUsers{bsnAPIfSlotId="0",bsnAPName="0xABCDEF"} 0

After:

bsnApIfNoOfUsers{bsnAPIfSlotId="0",bsnAPName="AP-NAME"} 0

@devon-mar devon-mar force-pushed the apname-fix branch 2 times, most recently from ab9c18d to 0f5313a Compare May 28, 2021 06:14
SuperQ
SuperQ requested changes Aug 27, 2023
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a rebase.

@devon-mar devon-mar closed this Aug 27, 2023
@devon-mar devon-mar reopened this Aug 27, 2023
@SuperQ
Copy link
Member

SuperQ commented Aug 27, 2023

This needs a DCO sign-off. You can use git commit -s --amend to add it.

@SuperQ
Copy link
Member

SuperQ commented Aug 27, 2023

The generator CI is broken right now due to one of the vendors with an expired https cert. :(

@devon-mar devon-mar requested a review from SuperQ August 27, 2023 19:43
@SuperQ SuperQ merged commit c4cf5e2 into prometheus:main Sep 18, 2023
2 checks passed
chanjarster pushed a commit to chanjarster/snmp_exporter that referenced this pull request Sep 19, 2023
@devon-mar @chanjarster
Override bsnAPName to DisplayString (prometheus#660)
ac0e5e7 
Signed-off-by: Devon Mar <[email protected]>
chanjarster pushed a commit to chanjarster/snmp_exporter that referenced this pull request Sep 19, 2023
@devon-mar @chanjarster
Override bsnAPName to DisplayString (prometheus#660)
6b46c95 
Signed-off-by: Devon Mar <[email protected]>
stephan-windischmann-sky pushed a commit to stephan-windischmann-sky/snmp_exporter that referenced this pull request Oct 27, 2023
@devon-mar
Override bsnAPName to DisplayString (prometheus#660)
4f67b90 
Signed-off-by: Devon Mar <[email protected]>
Signed-off-by: Stephan Windischmann <[email protected]>
SuperQ added a commit that referenced this pull request Nov 24, 2023
@SuperQ
Release v0.25.0
864bc26 
* [ENHANCEMENT] generator: Add support for subsequent address family #782
* [ENHANCEMENT] generator: Fix lookups to match OIDs closer to the index OID. #828
* [FEATURE] Add a scaling factor #1026
* [FEATURE] generator: Enable passing input file, output file, and mibs dir as flags #1028
* [FEATURE] Add an offset factor #1029
* [BUGFIX] Fix and optimize generator Docker image building #1045

snmp.yml changes:

* Override `bsnAPName` to DisplayString #660
* Import TP-Link EAP MIB  #833
* Updated Mikrotik neighbor indexes make them unique #986
* Update PowerNet MIB to v4.5.1 #1003
* Refactor HOST-RESOURCES-MIB #1027
* Update keepalived MIB files to latest version #1044

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ mentioned this pull request Nov 24, 2023
Merged
SuperQ added a commit that referenced this pull request Nov 26, 2023
@SuperQ
Release v0.25.0
81d8785 
* [ENHANCEMENT] generator: Add support for subsequent address family #782
* [ENHANCEMENT] generator: Fix lookups to match OIDs closer to the index OID. #828
* [FEATURE] Add a scaling factor #1026
* [FEATURE] generator: Enable passing input file, output file, and mibs dir as flags #1028
* [FEATURE] Add an offset factor #1029
* [BUGFIX] Fix and optimize generator Docker image building #1045

snmp.yml changes:

* Override `bsnAPName` to DisplayString #660
* Import TP-Link EAP MIB  #833
* Updated Mikrotik neighbor indexes make them unique #986
* Update PowerNet MIB to v4.5.1 #1003
* Refactor HOST-RESOURCES-MIB #1027
* Update keepalived MIB files to latest version #1044

Signed-off-by: SuperQ <[email protected]>
SuperQ added a commit that referenced this pull request Dec 6, 2023
@SuperQ
Release v0.25.0
8dafa43 
* [ENHANCEMENT] generator: Add support for subsequent address family #782
* [ENHANCEMENT] generator: Fix lookups to match OIDs closer to the index OID. #828
* [FEATURE] Add a scaling factor #1026
* [FEATURE] generator: Enable passing input file, output file, and mibs dir as flags #1028
* [FEATURE] Add an offset factor #1029
* [BUGFIX] Fix and optimize generator Docker image building #1045

snmp.yml changes:

* Override `bsnAPName` to DisplayString #660
* Import TP-Link EAP MIB  #833
* Updated Mikrotik neighbor indexes make them unique #986
* Update PowerNet MIB to v4.5.1 #1003
* Refactor HOST-RESOURCES-MIB #1027
* Update keepalived MIB files to latest version #1044

Signed-off-by: SuperQ <[email protected]>
SuperQ added a commit that referenced this pull request Dec 10, 2023
@SuperQ
Release v0.25.0 (#1052)
ea9e638 
* [ENHANCEMENT] generator: Add support for subsequent address family #782
* [ENHANCEMENT] generator: Fix lookups to match OIDs closer to the index OID. #828
* [FEATURE] Add a scaling factor #1026
* [FEATURE] generator: Enable passing input file, output file, and mibs dir as flags #1028
* [FEATURE] Add an offset factor #1029
* [BUGFIX] Fix and optimize generator Docker image building #1045

snmp.yml changes:

* Override `bsnAPName` to DisplayString #660
* Import TP-Link EAP MIB  #833
* Updated Mikrotik neighbor indexes make them unique #986
* Update PowerNet MIB to v4.5.1 #1003
* Refactor HOST-RESOURCES-MIB #1027
* Update keepalived MIB files to latest version #1044

Signed-off-by: SuperQ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devon-mar @SuperQ