look up EnumAsInfo indexes in enum_values #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frederic Van Espen <[email protected]>
added 2 commits
August 31, 2020 10:35
* add generator test * reformat Signed-off-by: Frederic Van Espen <[email protected]>
Signed-off-by: Frederic Van Espen <[email protected]>
Signed-off-by: Frederic Van Espen <[email protected]>
Signed-off-by: Frederic Van Espen <[email protected]>
|
Added collector and generator tests. Can you verify if these are OK? I'm not entirely sure it's correct. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #477
Adds the index enum_values in the generated snmp.yml file and then uses that to look it up during scrape.