-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overrides for Synology MIB #556
Conversation
83c5572
to
c9149e0
Compare
Can you regenerate snmp.yml with the latest MIBs? |
f806336
to
deea5f6
Compare
CI is still failing, make sure you have the latest mibs. |
@brian-brazil Done. But apparently there were a few unrelated changes that were caused by |
Hmm, are you sure the generator is built from the latest head? |
Yes, latest commit (before mine) is 1b3b053. |
The only diff I'm seeing on head is for |
Ok, that’s the problem. I can rebuild |
The |
Ok, @koraktor, please rebase against head, that should fix up the unrelated diff. |
deea5f6
to
effa84d
Compare
Still failing because of the missing |
That could be macos related. Depends on what version of net-snmp you've compiled against. |
Building on Ubuntu results in the same file. Both Ubuntu and macOS use newer versions of Net-SNMP (5.8 and 5.9) than the Circle CI build (5.7). |
I'm on Ubuntu 20.04/net-snmp 5.8. A freshly built generator doesn't drop the You could try using the Docker generator instructions, then it would match what's in CI. |
effa84d
to
37a6ea0
Compare
I thought it wouldn’t be worth the hassle to fix the build for a text file that can be cleaned up manually. So I did that for the Now there’s one last problem: |
Hmm, that's odd. It works for me locally too. |
37a6ea0
to
54af7f0
Compare
54af7f0
to
1bd7520
Compare
Rebased on |
Signed-off-by: Sebastian Staudt <[email protected]>
Signed-off-by: Sebastian Staudt <[email protected]>
1bd7520
to
0771968
Compare
Rebased on Any chance to get this merged now? @brian-brazil @SuperQ |
Thanks! |
This adds overrides for the Synology MIB to increase usefulness of the prodived metrics.
Human-readable strings are now provided as
DisplayString
values. The metricsraidFreeSize
andraidTotalSize
are now gauges.