Add automatic Conter64 wrapping #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
force-pushed
the
superq/wrap_large_counters
branch
from
3d47144 to
9103dd8
Compare
SuperQ
force-pushed
the
superq/wrap_large_counters
branch
2 times, most recently
from
04706dd to
1a52b32
Compare
squeed
reviewed
Nov 2, 2018
SuperQ
force-pushed
the
superq/wrap_large_counters
branch
from
1a52b32 to
e7d9f24
Compare
brian-brazil
reviewed
Nov 2, 2018
Automatically wrap Counter64 PDU values every 2^53 to avoid float64 precision loss. Add a command line flag to enable/disable this feature, enable by default. Signed-off-by: Ben Kochie <[email protected]>
SuperQ
force-pushed
the
superq/wrap_large_counters
branch
from
e7d9f24 to
dfa3c0d
Compare
|
I would state at what value you wrap. Else, lgtm given the other comments.
Sent by mobile; please excuse my brevity.
…On Fri, Nov 2, 2018, 10:39 Ben Kochie ***@***.*** wrote:
Automatically wrap Counter64 PDU values every 2^53 to avoid float64
precision loss.
Add a command line flag to enable/disable this feature, enable by
default.
Signed-off-by: Ben Kochie ***@***.***
Closes: #350 <#350>
------------------------------
You can view, comment on, or merge this pull request online at:
#351
Commit Summary
- Add automatic Conter64 wrapping
File Changes
- *M* README.md
<https://github.com/prometheus/snmp_exporter/pull/351/files#diff-0>
(7)
- *M* collector.go
<https://github.com/prometheus/snmp_exporter/pull/351/files#diff-1>
(7)
- *M* collector_test.go
<https://github.com/prometheus/snmp_exporter/pull/351/files#diff-2>
(34)
- *M* main.go
<https://github.com/prometheus/snmp_exporter/pull/351/files#diff-3>
(1)
Patch Links:
- https://github.com/prometheus/snmp_exporter/pull/351.patch
- https://github.com/prometheus/snmp_exporter/pull/351.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#351>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAuEIy8iuQ09SpexmfcfVhEDiz7BqawTks5urBLqgaJpZM4YLU7->
.
|
brian-brazil
pushed a commit
that referenced
this pull request
Feb 5, 2019
Automatically wrap Counter64 PDU values every 2^53 to avoid float64 precision loss. Add a command line flag to enable/disable this feature, enable by default. Signed-off-by: Ben Kochie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically wrap Counter64 PDU values every 2^53 to avoid float64
precision loss.
Add a command line flag to enable/disable this feature, enable by
default.
Signed-off-by: Ben Kochie [email protected]
Closes: #350