Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LLDP-MIB's LldpPortId #337

Merged
merged 2 commits into from
Sep 24, 2018
Merged

Add support for LLDP-MIB's LldpPortId #337

merged 2 commits into from
Sep 24, 2018

Conversation

brian-brazil
Copy link
Contributor

collector.go Outdated
}
} else {
metricType = "OctetString"
log.Debugf("Unable to find InetAddressType at %s for %s", prevOid, metric.Name)
log.Debugf("Unable to find tyoe at %s for %s", prevOid, metric.Name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I like the lookup table, seems much cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants