Add NTPTimeStamp type #1315
Open
Add NTPTimeStamp type #1315
+62
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phibos
force-pushed
the
ntp_timestamp
branch
from
0909a59 to
d91a9bd
Compare
collector/collector.go
Outdated
| func parseNtpTimestamp(pdu *gosnmp.SnmpPDU) (float64, error) { | ||
| var data []byte = pdu.Value.([]byte) | ||
|
|
||
| // 2208988800 is the Unix Epoch in NTP Seconds (1970 - 1900) |
There was a problem hiding this comment.
we should include a hint that the returned data is "Seconds and Fractions since 01.01.1900" as the ntp era starts on jan 1st 1900 whereas unix epoch starts 70y later (so the 2208988800 is basically the offset between those two eras)
There was a problem hiding this comment.
I have added a comment with additional information, rebased against current main branch and pushed the changes.
Feel free to have a look.
Parse the ntp timestamp and convert it to an unix timestamp Signed-off-by: PhiBo <[email protected]>
phibos
force-pushed
the
ntp_timestamp
branch
from
d06510e to
25feabb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse the ntp timestamp and convert it to an unix timestamp.
Used in different MIBs
At the moment I have tested it with some Cisco devices.
I have tried to add some tests, but I don't know if something is missing.