Add a limit in the graph code for number of metrics #6100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids running each metric name through several function calls by doing the fuzzy filtering earlier. It also moves the history construction into the function rather than multiple places. Signed-off-by: David Leadbeater <[email protected]>
Browsers start to get slow if this element has more than around 5,000 items in it. Signed-off-by: David Leadbeater <[email protected]>
Signed-off-by: David Leadbeater <[email protected]>
Signed-off-by: David Leadbeater <[email protected]>
Signed-off-by: David Leadbeater <[email protected]>
dgl
added a commit
to dgl/thanos
that referenced
this pull request
Oct 4, 2019
This imports the changes from the currently unmerged pull request at prometheus/prometheus#6100. Signed-off-by: David Leadbeater <[email protected]>
1 task
dgl
added a commit
to dgl/thanos
that referenced
this pull request
Oct 4, 2019
This imports the changes from the currently unmerged pull request at prometheus/prometheus#6100. Signed-off-by: David Leadbeater <[email protected]>
Signed-off-by: David Leadbeater <[email protected]>
|
Any updates on this? On the Thanos side, this kind of code makes sense where we easily have terabytes of data and solves the original problem mentioned here but I also think it's understandable if on the Prometheus' side you don't want to have such logic embedded in the UI's code. |
2 tasks
|
@juliusv is this still relevant? |
|
Closing, would need updating for the new UI anyway (which mostly seems faster, although the fuzzy matching still seems expensive). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus a few optimisations, this improves the situation for #5919.