util: throw if file has !digit characters #614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throw if file has non-numeric data, in addition to hinting the path that caused the error. Fixes: prometheus#304, prometheus/node_exporter#1710 Signed-off-by: Pranshu Srivastava <[email protected]>
|
See ci errors |
Signed-off-by: Pranshu Srivastava <[email protected]>
SuperQ
requested changes
Apr 15, 2024
| if string(c) == "\n" { | ||
| continue | ||
| } | ||
| if !unicode.IsDigit(rune(c)) { |
There was a problem hiding this comment.
Hmm, this is going to match a whole bunch of unicode glyph runes that are not [0-9]. I think we should be more strict and check like this:
Suggested change
| if !unicode.IsDigit(rune(c)) { | |
| if !strings.ContainsAny(c, "0123456789") { |
SuperQ
requested changes
Apr 15, 2024
There was a problem hiding this comment.
Actually, looking at the upstream issue, we already see that this function is returning strconv.ErrSyntax from strconv.ParseUint(). I think the issue is the node_exporter is just not ignoring this specific error.
I don't think we need to make this change as the upstream strconv.ParseUint() is already doing a rune check on the string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw if file has non-numeric data, in addition to hinting the path that caused the error.
Fixes: #304, prometheus/node_exporter#1710