Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hw_counters for infiniband device. #549

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

aztecher
Copy link
Contributor

This change adds hw_counters to the existing infiniband class so that additional counter information for infiniband devices can be obtained.

In preparing this PR, I have confirmed that hw_counters for Infiniband devices can be obtained from the mlx5_core kernel module included in multiple Linux distributions and multiple OS versions.
I have also confirmed that it is possible to get hw_counters from the mlx5_core kernel module included in the OFED driver.
However, I have not checked for other cases (e.g. mlx4_core), so this implementation is limited to mlx5 only.

Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ SuperQ merged commit ce949a5 into prometheus:master Sep 22, 2023
jritter pushed a commit to jritter/procfs that referenced this pull request Jul 15, 2024
@gangxie112
Copy link

Which release of the node-exporter will include this change?

@discordianfish
Copy link
Member

Which release of the node-exporter will include this change?

The next one, we'll release a new version probably soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants