return error if cpufreq's are empty #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes prometheus/node_exporter#2198 when collector successful but empty |
SuperQ
requested changes
Dec 17, 2022
sysfs/system_cpu.go
Outdated
| @@ -178,6 +180,10 @@ func (fs FS) SystemCpufreq() ([]SystemCPUCpufreqStats, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| if len(systemCpufreq) == 0 { | |||
| return nil, fmt.Errorf("could not find any cpufreq files") | |||
There was a problem hiding this comment.
Two issues. We need to make an identifiable error so that downstream can tell a "not found" vs a parsing error.
For example, we could return os.ErrNotExist.
Or we make a new procfs error var with errors.New().
This way we can use errors.Is().
There was a problem hiding this comment.
Maybe return fmt.Errorf("could not find any cpufreq files: %w", os.ErrNotExist)?
Signed-off-by: Sergei Semenchuk <[email protected]>
binjip978
force-pushed
the
return-error-on-empty-cpu-freq
branch
from
24c58f6 to
b9fa528
Compare
SuperQ
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sergei Semenchuk [email protected]