Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CmdLine function to parse /proc/cmdline #393

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

bdrung
Copy link
Contributor

@bdrung bdrung commented Jul 5, 2021

Our company internal Prometheus exporter uses the procfs library and needs to read /proc/cmdline. Since fs.proc.Path cannot be accessed from outside, add CmdLine to procfs to read /proc/cmdline.

Our company internal Prometheus exporter uses the procfs library and
needs to read `/proc/cmdline`. Since `fs.proc.Path` cannot be accessed
from outside, add `CmdLine` to procfs to read `/proc/cmdline`.

Signed-off-by: Benjamin Drung <[email protected]>
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@SuperQ SuperQ requested a review from discordianfish July 5, 2021 13:54
@SuperQ SuperQ merged commit b62dc6f into prometheus:master Jul 5, 2021
@bdrung bdrung deleted the cmdline branch July 6, 2021 07:43
remijouannet pushed a commit to remijouannet/procfs that referenced this pull request Oct 20, 2022
Our company internal Prometheus exporter uses the procfs library and
needs to read `/proc/cmdline`. Since `fs.proc.Path` cannot be accessed
from outside, add `CmdLine` to procfs to read `/proc/cmdline`.

Signed-off-by: Benjamin Drung <[email protected]>
jritter pushed a commit to jritter/procfs that referenced this pull request Jul 15, 2024
Our company internal Prometheus exporter uses the procfs library and
needs to read `/proc/cmdline`. Since `fs.proc.Path` cannot be accessed
from outside, add `CmdLine` to procfs to read `/proc/cmdline`.

Signed-off-by: Benjamin Drung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants