Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CPUInfo parsing for RISCV #318

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

tklauser
Copy link
Contributor

Currently only 64-bit RISCV is supported (GOARCH=riscv64) by the Go
compiler, but the cpuinfo format would be the same for 32-bit RISCV.

Signed-off-by: Tobias Klauser [email protected]

Currently only 64-bit RISCV is supported (GOARCH=riscv64) by the Go
compiler, but the cpuinfo format would be the same for 32-bit RISCV.

Signed-off-by: Tobias Klauser <[email protected]>
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@discordianfish
Copy link
Member

Thanks!

@discordianfish discordianfish merged commit 9e1fd81 into prometheus:master Aug 26, 2020
@tklauser tklauser deleted the cpuinfo-riscv64 branch August 26, 2020 09:29
tklauser added a commit to tklauser/procfs that referenced this pull request Sep 7, 2020
PR prometheus#318 forgot to wire parseCPUInfo to parseCPUInfoRISCV on
GOARCH=riscv{,64}, leading to a build/test failure:

./cpuinfo.go:71:9: undefined: parseCPUInfo
./cpuinfo_test.go:222:2: undefined: parseCPUInfo

Signed-off-by: Tobias Klauser <[email protected]>
@tklauser tklauser mentioned this pull request Sep 7, 2020
discordianfish pushed a commit that referenced this pull request Nov 2, 2020
PR #318 forgot to wire parseCPUInfo to parseCPUInfoRISCV on
GOARCH=riscv{,64}, leading to a build/test failure:

./cpuinfo.go:71:9: undefined: parseCPUInfo
./cpuinfo_test.go:222:2: undefined: parseCPUInfo

Signed-off-by: Tobias Klauser <[email protected]>
remijouannet pushed a commit to remijouannet/procfs that referenced this pull request Oct 20, 2022
PR prometheus#318 forgot to wire parseCPUInfo to parseCPUInfoRISCV on
GOARCH=riscv{,64}, leading to a build/test failure:

./cpuinfo.go:71:9: undefined: parseCPUInfo
./cpuinfo_test.go:222:2: undefined: parseCPUInfo

Signed-off-by: Tobias Klauser <[email protected]>
wanghao75 pushed a commit to openeuler-mirror/node_exporter that referenced this pull request Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants