-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CPUInfo parsing for RISCV #318
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently only 64-bit RISCV is supported (GOARCH=riscv64) by the Go compiler, but the cpuinfo format would be the same for 32-bit RISCV. Signed-off-by: Tobias Klauser <[email protected]>
tklauser
force-pushed
the
cpuinfo-riscv64
branch
from
July 22, 2020 09:58
116503e
to
1fc4512
Compare
SuperQ
approved these changes
Aug 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
discordianfish
approved these changes
Aug 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! |
tklauser
added a commit
to tklauser/procfs
that referenced
this pull request
Sep 7, 2020
PR prometheus#318 forgot to wire parseCPUInfo to parseCPUInfoRISCV on GOARCH=riscv{,64}, leading to a build/test failure: ./cpuinfo.go:71:9: undefined: parseCPUInfo ./cpuinfo_test.go:222:2: undefined: parseCPUInfo Signed-off-by: Tobias Klauser <[email protected]>
Merged
discordianfish
pushed a commit
that referenced
this pull request
Nov 2, 2020
PR #318 forgot to wire parseCPUInfo to parseCPUInfoRISCV on GOARCH=riscv{,64}, leading to a build/test failure: ./cpuinfo.go:71:9: undefined: parseCPUInfo ./cpuinfo_test.go:222:2: undefined: parseCPUInfo Signed-off-by: Tobias Klauser <[email protected]>
remijouannet
pushed a commit
to remijouannet/procfs
that referenced
this pull request
Oct 20, 2022
PR prometheus#318 forgot to wire parseCPUInfo to parseCPUInfoRISCV on GOARCH=riscv{,64}, leading to a build/test failure: ./cpuinfo.go:71:9: undefined: parseCPUInfo ./cpuinfo_test.go:222:2: undefined: parseCPUInfo Signed-off-by: Tobias Klauser <[email protected]>
wanghao75
pushed a commit
to openeuler-mirror/node_exporter
that referenced
this pull request
Jun 2, 2024
prometheus/procfs#318 325 Signed-off-by: laokz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only 64-bit RISCV is supported (GOARCH=riscv64) by the Go
compiler, but the cpuinfo format would be the same for 32-bit RISCV.
Signed-off-by: Tobias Klauser [email protected]