Moved all mysql commands to mysql_commands_total and use Untyped for all other metrics. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| func (e *Exporter) setMetrics(scrapes <-chan []string) { | ||
| for row := range scrapes { | ||
| var comRegex, _ = regexp.Compile(`^com_(.*)$`) |
There was a problem hiding this comment.
Use MustCompile here. This'd be better as a global constant.
|
Status on this one? I saw one more commit being pushed after @brian-brazil's last comment. |
|
@juliusv the last commit should fix the issues that @brian-brazil has mentioned in comments. |
| for row := range scrapes { | ||
| var comRegex = regexp.MustCompile(`^com_(.*)$`) | ||
| var connectionErrorRegex = regexp.MustCompile(`^connection_errors_(.*)$`) | ||
| var handlerRegex = regexp.MustCompile(`^handler_(.*)$`) |
There was a problem hiding this comment.
I don't think these make sense as one metric, they're all for very different things
|
👍 |
|
@siavashs Woot. Could you squash your commmits so I can merge? |
Use Untyped for all other metrics. Parse directly to float and remove all value conversions.
|
@juliusv done :) |
|
Woot, thanks! Merging. :) |
juliusv
added a commit
that referenced
this pull request
Jun 23, 2015
Moved all mysql commands to mysql_commands_total and use Untyped for all other metrics.
|
No problem ;) |
ezraroi
pushed a commit
to ezraroi/mysqld_exporter
that referenced
this pull request
Apr 17, 2018
# This is the 1st commit message: Move session params to DSN (prometheus#259) * Move session params to DSN In order to avoid lost session params if the `db` object reconnects in the background, move session params to the DSN string configuration. * Move log_slow_filter flag to exporter * Update flag name to be in `exporter` namespace. * Update README. * Tweak exporter.log_slow_filter flag documentation. # This is the commit message prometheus#2: Fix lock_wait_timeout after prometheus#259 (prometheus#263) # This is the commit message prometheus#3: Broken landing page, doesn't include metric path. (prometheus#264) * Broken landing page, doesn't include metric path. * Fix landing page. # This is the commit message prometheus#4: first commit Signed-off-by: Roi Ezra <[email protected]> # This is the commit message prometheus#5: fixed code review Signed-off-by: Roi Ezra <[email protected]> # This is the commit message prometheus#6: fixed code review Signed-off-by: Roi Ezra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.