Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prefix removal in perf_schema_file_instances #257

Merged
merged 1 commit into from
Jan 10, 2018
Merged

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented Jan 10, 2018

Splitting on path is unsafe if two tables have the same name, but are in
different databases. Use a single string prefix to remove the noisy
path data from the labels.

Closes: #256

Splitting on path is unsafe if two tables have the same name, but are in
different databases.  Use a single string prefix to remove the noisy
path data from the labels.
@SuperQ
Copy link
Member Author

SuperQ commented Jan 10, 2018

/CC @jaloren

@SuperQ
Copy link
Member Author

SuperQ commented Jan 10, 2018

/CC @rtreffer

@SuperQ SuperQ requested a review from matthiasr January 10, 2018 08:17
@brian-brazil
Copy link
Contributor

👍

Copy link
Contributor

@rtreffer rtreffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@SuperQ SuperQ merged commit da3c16f into master Jan 10, 2018
@SuperQ SuperQ deleted the superq/file_trim branch January 10, 2018 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mysqld exporter generates duplicate mysql_perf_schema_file_instance* metrics when there are multiple databases
3 participants