Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to kingpin #222

Merged
merged 1 commit into from
Oct 8, 2017
Merged

Switch to kingpin #222

merged 1 commit into from
Oct 8, 2017

Conversation

carlpett
Copy link
Member

Switch flag handling to kingpin as per Prometheus #2455.

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ
Copy link
Member

SuperQ commented Aug 26, 2017

FYI, this needs to be rebased.

@carlpett
Copy link
Member Author

carlpett commented Sep 3, 2017

Done

@SuperQ SuperQ merged commit ad4138a into prometheus:master Oct 8, 2017
alexjfisher pushed a commit to voxpupuli/puppet-prometheus that referenced this pull request Aug 22, 2018
Flags now use the Kingpin library, and require double-dashes. prometheus/mysqld_exporter#222
cegeka-jenkins pushed a commit to cegeka/puppet-prometheus that referenced this pull request Aug 28, 2019
Flags now use the Kingpin library, and require double-dashes. prometheus/mysqld_exporter#222
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this pull request May 5, 2021
Flags now use the Kingpin library, and require double-dashes. prometheus/mysqld_exporter#222
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants