Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump prometheus/statsd_exporter to v0.8.1 and prometheus/client_golang to v0.9.2 #77

Merged
merged 3 commits into from
Feb 28, 2019

Conversation

fffonion
Copy link
Contributor

@fffonion fffonion commented Feb 27, 2019

@matthiasr

This also bumps prometheus/client_golang to v0.9.2
so we pass checksum in go>=1.11.4

Fix #70 #69

This also bumps prometheus/client_golang to v0.8.0
automatically according to dependency of statsd_exporter.

Signed-off-by: Wangchong Zhou <[email protected]>
@fffonion fffonion force-pushed the chore/bump-up-statsd-exporter branch from 4141320 to 3d56a15 Compare February 27, 2019 23:37
@fffonion fffonion changed the title Bump prometheus/statsd_exporter to v0.8.1 Bump prometheus/statsd_exporter to v0.8.1 and prometheus/client_golang to v0.9.2 Feb 27, 2019
@fffonion fffonion force-pushed the chore/bump-up-statsd-exporter branch from 07705d8 to b7e2adf Compare February 28, 2019 00:42
@fffonion fffonion force-pushed the chore/bump-up-statsd-exporter branch from b7e2adf to 6dcfdb8 Compare February 28, 2019 00:48
@matthiasr
Copy link
Contributor

Wonderful, thanks a lot!

For my education, what commands did you use to entice Go modules to update and pass the checks? This is something I have struggled with a lot.

@matthiasr matthiasr merged commit 8abf106 into prometheus:master Feb 28, 2019
matthiasr pushed a commit that referenced this pull request Feb 28, 2019
add #77 to the changelog, bump version.

Signed-off-by: Matthias Rampke <[email protected]>
@fffonion
Copy link
Contributor Author

Yes sure it was

# locks updated module in go.mod
go get github.com/prometheus/[email protected]
# updates the vendor/ dir
go mod vendor
# cleanup unused modules
go mod tidy

For client_golang, I manually bumped other helper modules from github.com/prometheus as well, copy-pasting from go.mod in statsd_exporter. Not sure if this is the right way to do though.

Also it might be a good idea to do those in a clear environment (like in a docker), I've had a bad time with my weird dev environment.

@matthiasr
Copy link
Contributor

matthiasr commented Feb 28, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants