main: return 404 in the root HTTP handler iff path is not "/" #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return 404 in the root HTTP handler iff the path is not "/" so that the users would be able to access other end-points such as "/debug/pprof/heap" and so on. Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
force-pushed
the
fix_root_handler
branch
from
79364b0
to
f851151
Compare
|
thank you! |
matthiasr
pushed a commit
that referenced
this pull request
Dec 5, 2018
Signed-off-by: Matthias Rampke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return 404 in the root HTTP handler iff the path is not "/" so that the
users would be able to access other end-points such as
"/debug/pprof/heap" and so on.
Unblocks work on issue #66.